Commit 70597f21 authored Aug 02, 2010 by Arnaldo Carvalho de Melo

perf session: Invalidate last_match when removing threads from rb_tree



If we receive two PERF_RECORD_EXIT for the same thread, we can end up
reusing session->last_match and trying to remove the thread twice from
the rb_tree, causing a segfault, so invalidade last_match in
perf_session__remove_thread.

Receiving two PERF_RECORD_EXIT for the same thread is a bug, but its a
harmless one if we make the tool more robust, like this patch does.

Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 076c6e45

tools/perf/util/session.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -166,6 +166,7 @@ void perf_session__delete(struct perf_session *self)

		void perf_session__remove_thread(struct perf_session self, struct thread th)
		{
		self->last_match = NULL;
		rb_erase(&th->rb_node, &self->threads);
		/*
		* We may have references to this thread, for instance in some hist_entry