Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7053fdac authored by Daniel Lezcano's avatar Daniel Lezcano
Browse files

clocksource/drivers/h8300_timer8: Remove pointless irq re-entrant safe code 



The current code assumes the interrupt function is re-entrant.

That is not correct. An interrupt handler is never invoked concurrently. The
interrupt line is masked on all processors.

Remove the chewing flags in the code.

Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
parent 54a0cd5a

drivers/clocksource/h8300_timer8.c

+6 −9
Original line number Diff line number Diff line
@@ -24,8 +24,6 @@ 
#define TCORB	6

#define _8TCNT	8



#define FLAG_SKIPEVENT (1 << 1)

#define FLAG_IRQCONTEXT (1 << 2)

#define FLAG_STARTED (1 << 3)



#define SCALE 64
@@ -67,14 +65,13 @@ static irqreturn_t timer8_interrupt(int irq, void *dev_id) 


	ctrl_outb(ctrl_inb(p->mapbase + _8TCSR) & ~0x40,

		  p->mapbase + _8TCSR);

	p->flags |= FLAG_IRQCONTEXT;



	ctrl_outw(p->tcora, p->mapbase + TCORA);

	if (!(p->flags & FLAG_SKIPEVENT)) {



	if (clockevent_state_oneshot(&p->ced))

		ctrl_outw(0x0000, p->mapbase + _8TCR);



	p->ced.event_handler(&p->ced);

	}

	p->flags &= ~(FLAG_SKIPEVENT | FLAG_IRQCONTEXT);



	return IRQ_HANDLED;

}