Commit 6f9c2963 authored Apr 26, 2006 by Jean Delvare Committed by Greg Kroah-Hartman May 09, 2006

[PATCH] scx200_acb: Fix return on init error



The scx200_acb driver shouldn't return failure after initialization
if it successfully registered at least one i2c_adapter, else we are
leaking resources. The driver was OK in that respect up to 2.6.16, a
recent change broke it.

This is part of the fix to bug #6445.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Ben Gardner <bgardner@wabtec.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent e515f048

drivers/i2c/busses/scx200_acb.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -524,6 +524,9 @@ static int __init scx200_acb_init(void)
		} else if (pci_dev_present(divil_pci))
		rc = scx200_add_cs553x();

		/* If at least one bus was created, init must succeed */
		if (scx200_acb_list)
		return 0;
		return rc;
		}