Commit 6f73d3b1 authored Jan 12, 2015 by Ying Xue Committed by David S. Miller Jan 13, 2015

rhashtable: add a note for grow and shrink decision functions



As commit c0c09bfd ("rhashtable: avoid unnecessary wakeup for
worker queue") moves condition statements of verifying whether hash
table size exceeds its maximum threshold or reaches its minimum
threshold from resizing functions to resizing decision functions,
we should add a note in rhashtable.h to indicate the implementation
of what the grow and shrink decision function must enforce min/max
shift, otherwise, it's failed to take min/max shift's set watermarks
into effect.

Signed-off-by: Ying Xue <ying.xue@windriver.com>
Cc: Thomas Graf <tgraf@suug.ch>
Acked-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c5adde94

include/linux/rhashtable.h

+4 −0

Original line number	Diff line number	Diff line
		@@ -79,6 +79,10 @@ struct rhashtable;
		* @obj_hashfn: Function to hash object
		* @grow_decision: If defined, may return true if table should expand
		* @shrink_decision: If defined, may return true if table should shrink
		*
		* Note: when implementing the grow and shrink decision function, min/max
		* shift must be enforced, otherwise, resizing watermarks they set may be
		* useless.
		*/
		struct rhashtable_params {
		size_t nelem_hint;