Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6f3a539e authored by Eric Paris's avatar Eric Paris
Browse files

fsnotify: use kmem_cache_zalloc to simplify event initialization 



fsnotify event initialization is done entry by entry with almost everything
set to either 0 or NULL.  Use kmem_cache_zalloc and only initialize things
that need non-zero initialization.  Also means we don't have to change
initialization entries based on the config options.

Signed-off-by: default avatarEric Paris <eparis@redhat.com>
parent f0553af0

fs/notify/notification.c

+1 −12
Original line number Diff line number Diff line
@@ -314,25 +314,14 @@ void fsnotify_flush_notify(struct fsnotify_group *group) 


static void initialize_event(struct fsnotify_event *event)

{

	event->holder.event = NULL;

	INIT_LIST_HEAD(&event->holder.event_list);

	atomic_set(&event->refcnt, 1);



	spin_lock_init(&event->lock);



	event->path.dentry = NULL;

	event->path.mnt = NULL;

	event->inode = NULL;

	event->data_type = FSNOTIFY_EVENT_NONE;



	INIT_LIST_HEAD(&event->private_data_list);



	event->to_tell = NULL;



	event->file_name = NULL;

	event->name_len = 0;



	event->sync_cookie = 0;

}



/*
@@ -353,7 +342,7 @@ struct fsnotify_event *fsnotify_create_event(struct inode *to_tell, __u32 mask, 
{

	struct fsnotify_event *event;



	event = kmem_cache_alloc(fsnotify_event_cachep, gfp);

	event = kmem_cache_zalloc(fsnotify_event_cachep, gfp);

	if (!event)

		return NULL;