Commit 6f207e9b authored Nov 11, 2010 by Feng Tang Committed by Thomas Gleixner Nov 11, 2010

x86: mrst: Set vRTC's IRQ to level trigger type



When setting up the mpc_intsrc structure for vRTC's IRQ,
we need to set its irqflag to level trigger, otherwise
it will be taken as edge triggered and the vRTC IRQ will
fire only once, as there is never a EOI issued from the
IA core for it.

The original code worked in previous kernel. This is  because it
was configured to level trigger type by luck. It fell
into the default PCI trigger category which is level triggered.

Signed-off-by: Feng Tang <feng.tang@intel.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
LKML-Reference: <20101111155019.12924.569.stgit@localhost.localdomain>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent 86071535

arch/x86/platform/mrst/mrst.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -195,7 +195,7 @@ int __init sfi_parse_mrtc(struct sfi_table_header *table)
		totallen, (u32)pentry->phys_addr, pentry->irq);
		mp_irq.type = MP_IOAPIC;
		mp_irq.irqtype = mp_INT;
		mp_irq.irqflag = 0;
		mp_irq.irqflag = 0xf; /* level trigger and active low */
		mp_irq.srcbus = 0;
		mp_irq.srcbusirq = pentry->irq; /* IRQ */
		mp_irq.dstapic = MP_APIC_ALL;