Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6e909f74 authored by Alex Deucher's avatar Alex Deucher
Browse files

drm/radeon: add bapm module parameter 

Add a module paramter to enable bapm on APUs.  It's disabled
by default on certain APUs due to stability issues.  This
option makes it easier to test and to enable it on systems that
are stable.

bug:
https://bugzilla.kernel.org/show_bug.cgi?id=81021



Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
parent 25196484

drivers/gpu/drm/radeon/kv_dpm.c

+4 −1
Original line number Diff line number Diff line
@@ -2726,6 +2726,9 @@ int kv_dpm_init(struct radeon_device *rdev) 
	pi->caps_sclk_ds = true;

	pi->enable_auto_thermal_throttling = true;

	pi->disable_nb_ps3_in_battery = false;

	if (radeon_bapm == 0)

		pi->bapm_enable = false;

	else

		pi->bapm_enable = true;

	pi->voltage_drop_t = 0;

	pi->caps_sclk_throttle_low_notification = false;

drivers/gpu/drm/radeon/radeon.h

+1 −0
Original line number Diff line number Diff line
@@ -105,6 +105,7 @@ extern int radeon_vm_size; 
extern int radeon_vm_block_size;

extern int radeon_deep_color;

extern int radeon_use_pflipirq;

extern int radeon_bapm;



/*

 * Copy from radeon_drv.h so we don't have to include both and have conflicting

drivers/gpu/drm/radeon/radeon_drv.c

+4 −0
Original line number Diff line number Diff line
@@ -180,6 +180,7 @@ int radeon_vm_size = 8; 
int radeon_vm_block_size = -1;

int radeon_deep_color = 0;

int radeon_use_pflipirq = 2;

int radeon_bapm = -1;



MODULE_PARM_DESC(no_wb, "Disable AGP writeback for scratch registers");

module_param_named(no_wb, radeon_no_wb, int, 0444);
@@ -259,6 +260,9 @@ module_param_named(deep_color, radeon_deep_color, int, 0444); 
MODULE_PARM_DESC(use_pflipirq, "Pflip irqs for pageflip completion (0 = disable, 1 = as fallback, 2 = exclusive (default))");

module_param_named(use_pflipirq, radeon_use_pflipirq, int, 0444);



MODULE_PARM_DESC(bapm, "BAPM support (1 = enable, 0 = disable, -1 = auto)");

module_param_named(bapm, radeon_bapm, int, 0444);



static struct pci_device_id pciidlist[] = {

	radeon_PCI_IDS

};

drivers/gpu/drm/radeon/trinity_dpm.c

+15 −9
Original line number Diff line number Diff line
@@ -1874,6 +1874,7 @@ int trinity_dpm_init(struct radeon_device *rdev) 
	for (i = 0; i < SUMO_MAX_HARDWARE_POWERLEVELS; i++)

		pi->at[i] = TRINITY_AT_DFLT;



	if (radeon_bapm == -1) {

		/* There are stability issues reported on with

		 * bapm enabled when switching between AC and battery

		 * power.  At the same time, some MSI boards hang
@@ -1884,6 +1885,11 @@ int trinity_dpm_init(struct radeon_device *rdev) 
			pi->enable_bapm = true;

		else

			pi->enable_bapm = false;

	} else if (radeon_bapm == 0) {

		pi->enable_bapm = false;

	} else {

		pi->enable_bapm = true;

	}

	pi->enable_nbps_policy = true;

	pi->enable_sclk_ds = true;

	pi->enable_gfx_power_gating = true;