Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6e14eab9 authored by Nicholas Bellinger's avatar Nicholas Bellinger
Browse files

target/user: Fix up smatch warnings in tcmu_netlink_event 



This patch fixes up the following unused return smatch warnings:

  drivers/target/target_core_user.c:778 tcmu_netlink_event warn: unused return: ret = nla_put_string()
  drivers/target/target_core_user.c:780 tcmu_netlink_event warn: unused `return: ret = nla_put_u32()

(Fix up missing semicolon: grover)

Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 7c9e7a6f

drivers/target/target_core_user.c

+13 −10
Original line number Original line Diff line number Diff line
@@ -763,27 +763,27 @@ static int tcmu_netlink_event(enum tcmu_genl_cmd cmd, const char *name, int mino 
{

{

	struct sk_buff *skb;

	struct sk_buff *skb;

	void *msg_header;

	void *msg_header;

	int ret;

	int ret = -ENOMEM;





	skb = genlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);

	skb = genlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);

	if (!skb)

	if (!skb)

		return -ENOMEM;

		return ret;





	msg_header = genlmsg_put(skb, 0, 0, &tcmu_genl_family, 0, cmd);

	msg_header = genlmsg_put(skb, 0, 0, &tcmu_genl_family, 0, cmd);

	if (!msg_header) {

	if (!msg_header)

		nlmsg_free(skb);

		goto free_skb;

		return -ENOMEM;

	}





	ret = nla_put_string(skb, TCMU_ATTR_DEVICE, name);

	ret = nla_put_string(skb, TCMU_ATTR_DEVICE, name);

	if (ret < 0)

		goto free_skb;





	ret = nla_put_u32(skb, TCMU_ATTR_MINOR, minor);

	ret = nla_put_u32(skb, TCMU_ATTR_MINOR, minor);

	if (ret < 0)

		goto free_skb;





	ret = genlmsg_end(skb, msg_header);

	ret = genlmsg_end(skb, msg_header);

	if (ret < 0) {

	if (ret < 0)

		nlmsg_free(skb);

		goto free_skb;

		return ret;

	}





	ret = genlmsg_multicast(&tcmu_genl_family, skb, 0,

	ret = genlmsg_multicast(&tcmu_genl_family, skb, 0,

				TCMU_MCGRP_CONFIG, GFP_KERNEL);

				TCMU_MCGRP_CONFIG, GFP_KERNEL);
@@ -793,6 +793,9 @@ static int tcmu_netlink_event(enum tcmu_genl_cmd cmd, const char *name, int mino 
		ret = 0;

		ret = 0;





	return ret;

	return ret;

free_skb:

	nlmsg_free(skb);

	return ret;

}

}





static int tcmu_configure_device(struct se_device *dev)

static int tcmu_configure_device(struct se_device *dev)