Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6e00ff07 authored by Charles Keepax's avatar Charles Keepax Committed by Lee Jones
Browse files

mfd: arizona: Correct type of gpio_defaults 



gpio_defaults needs to be specified as an unsigned int rather than an
int, because the intention of the DT binding is that all out of range
values for a 16-bit register will cause the defaults to be used,
however, if gpio_defaults is an int then values that are larger than
INT_MAX will become negative numbers and be written out directly to the
hardware. As no where in the code replies on gpio_defaults being an int,
the simplest fix is to just change it to unsigned.

Signed-off-by: default avatarCharles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent aec9038e

include/linux/mfd/arizona/pdata.h

+1 −1
Original line number Diff line number Diff line
@@ -94,7 +94,7 @@ struct arizona_pdata { 
	int gpio_base;



	/** Pin state for GPIO pins */

	int gpio_defaults[ARIZONA_MAX_GPIO];

	unsigned int gpio_defaults[ARIZONA_MAX_GPIO];



	/**

	 * Maximum number of channels clocks will be generated for,