Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6dd6bca3 authored by Mark Asselstine's avatar Mark Asselstine Committed by Linus Torvalds
Browse files

mmc: sd: clean up redundant memset 



The clearing of mrq via a memset at the top of the for loop in
mmc_wait_for_app_cmd() is not required as mrq is not used and there is
another clearing of mrq just below.  We remove the first memset since if
the initial tests in the for loop fail the memset is not required.

Signed-off-by: default avatarMark Asselstine <asselsm@gmail.com>
Cc: <linux-mmc@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent bbce5802

drivers/mmc/core/sd_ops.c

+0 −2
Original line number Diff line number Diff line
@@ -79,8 +79,6 @@ int mmc_wait_for_app_cmd(struct mmc_host *host, struct mmc_card *card, 
	 * we cannot use the retries field in mmc_command.

	 */

	for (i = 0;i <= retries;i++) {

		memset(&mrq, 0, sizeof(struct mmc_request));



		err = mmc_app_cmd(host, card);

		if (err) {

			/* no point in retrying; no APP commands allowed */