Commit 6dd06d15 authored May 15, 2016 by Mahesh Salgaonkar Committed by Paul Mackerras Jun 20, 2016

powerpc/powernv: Remove the usage of PACAR1 from opal wrappers

OPAL_CALL wrapper code sticks the r1 (stack pointer) into PACAR1 purely
for debugging purpose only. The power7_wakeup* functions relies on stack
pointer saved in PACAR1. Any opal call made using opal wrapper (directly
or in-directly) before we fall through power7_wakeup*, then it ends up
replacing r1 in PACAR1(r13) leading to kernel panic. So far we don't see
any issues because we have never made any opal calls using OPAL wrapper
before power7_wakeup*. But the subsequent HMI patch would need to invoke
C calls during cpu wakeup/idle path that in-directly makes opal call using
opal wrapper. This patch facilitates the subsequent HMI patch by removing
usage of PACAR1 from opal call wrapper.

Signed-off-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>

parent b69890d1

arch/powerpc/platforms/powernv/opal-wrappers.S

+0 −2

Original line number	Diff line number	Diff line
		@@ -64,7 +64,6 @@ END_FTR_SECTION(0, 1); \
		OPAL_BRANCH(opal_tracepoint_entry) \
		mfcr r12; \
		stw r12,8(r1); \
		std r1,PACAR1(r13); \
		li r11,0; \
		mfmsr r12; \
		ori r11,r11,MSR_EE; \
		@@ -127,7 +126,6 @@ opal_tracepoint_entry:
		mfcr r12
		std r11,16(r1)
		stw r12,8(r1)
		std r1,PACAR1(r13)
		li r11,0
		mfmsr r12
		ori r11,r11,MSR_EE