Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6d8044b4 authored by Wolfram Sang's avatar Wolfram Sang Committed by Mark Brown
Browse files

ASoC: sh: rcar: core: don't open code of_device_get_match_data() 



This change will also make Coverity happy by avoiding a theoretical NULL
pointer dereference; yet another reason is to use the above helper function
to tighten the code and make it more readable.

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent b3fc95ad

sound/soc/sh/rcar/core.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -1119,7 +1119,6 @@ static int rsnd_probe(struct platform_device *pdev) 
	struct rsnd_priv *priv;

	struct rsnd_priv *priv;

	struct device *dev = &pdev->dev;

	struct device *dev = &pdev->dev;

	struct rsnd_dai *rdai;

	struct rsnd_dai *rdai;

	const struct of_device_id *of_id = of_match_device(rsnd_of_match, dev);

	int (*probe_func[])(struct rsnd_priv *priv) = {

	int (*probe_func[])(struct rsnd_priv *priv) = {

		rsnd_gen_probe,

		rsnd_gen_probe,

		rsnd_dma_probe,

		rsnd_dma_probe,
@@ -1145,7 +1144,7 @@ static int rsnd_probe(struct platform_device *pdev) 
	}

	}





	priv->pdev	= pdev;

	priv->pdev	= pdev;

	priv->flags	= (unsigned long)of_id->data;

	priv->flags	= (unsigned long)of_device_get_match_data(dev);

	spin_lock_init(&priv->lock);

	spin_lock_init(&priv->lock);





	/*

	/*