Commit 6cf95152 authored Nov 21, 2012 by Sachin Kamat Committed by Takashi Iwai Nov 21, 2012

ALSA: pcm: Fix return code in pcm_native.c



Return the value obtained from snd_pcm_hw_constraint_minmax() instead
of -EINVAL. Silences the following smatch warning:
sound/core/pcm_native.c:2003 snd_pcm_hw_constraints_complete() info:
why not propagate 'err' from snd_pcm_hw_constraint_minmax() instead of -22?

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 51d503de

sound/core/pcm_native.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2000,7 +2000,7 @@ int snd_pcm_hw_constraints_complete(struct snd_pcm_substream *substream)
		if (runtime->dma_bytes) {
		err = snd_pcm_hw_constraint_minmax(runtime, SNDRV_PCM_HW_PARAM_BUFFER_BYTES, 0, runtime->dma_bytes);
		if (err < 0)
		return -EINVAL;
		return err;
		}

		if (!(hw->rates & (SNDRV_PCM_RATE_KNOT \| SNDRV_PCM_RATE_CONTINUOUS))) {