Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6b6680c4 authored by Chen Gang's avatar Chen Gang Committed by Benjamin Herrenschmidt
Browse files

powerpc/pseries/hvcserver: Fix strncpy buffer limit in location code 



the dest buf len is 80 (HVCS_CLC_LENGTH + 1).
  the src buf len is PAGE_SIZE.
  if src buf string len is more than 80, it will cause issue.

Signed-off-by: default avatarChen Gang <gang.chen@asianux.com>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 27777890

arch/powerpc/platforms/pseries/hvcserver.c

+3 −2
Original line number Diff line number Diff line
@@ -23,6 +23,7 @@ 
#include <linux/list.h>

#include <linux/module.h>

#include <linux/slab.h>

#include <linux/string.h>



#include <asm/hvcall.h>

#include <asm/hvcserver.h>
@@ -188,9 +189,9 @@ int hvcs_get_partner_info(uint32_t unit_address, struct list_head *head, 
			= (unsigned int)last_p_partition_ID;



		/* copy the Null-term char too */

		strncpy(&next_partner_info->location_code[0],

		strlcpy(&next_partner_info->location_code[0],

			(char *)&pi_buff[2],

			strlen((char *)&pi_buff[2]) + 1);

			sizeof(next_partner_info->location_code));



		list_add_tail(&(next_partner_info->node), head);

		next_partner_info = NULL;