Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6b270fd4 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

TTY: bfin_jtag_comm: remove incorrect wait_until_sent operation 



Remove incorrect and redundant wait_until_sent operation, which waits
for the driver buffer rather than any hardware buffers to drain,
something which is already taken care of by the tty layer (and
chars_in_buffer).

Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Reviewed-by: default avatarPeter Hurley <peter@hurleysoftware.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2c3fbe3c

drivers/tty/bfin_jtag_comm.c

+0 −13
Original line number Diff line number Diff line
@@ -210,18 +210,6 @@ bfin_jc_chars_in_buffer(struct tty_struct *tty) 
	return circ_cnt(&bfin_jc_write_buf);

}



static void

bfin_jc_wait_until_sent(struct tty_struct *tty, int timeout)

{

	unsigned long expire = jiffies + timeout;

	while (!circ_empty(&bfin_jc_write_buf)) {

		if (signal_pending(current))

			break;

		if (time_after(jiffies, expire))

			break;

	}

}



static const struct tty_operations bfin_jc_ops = {

	.open            = bfin_jc_open,

	.close           = bfin_jc_close,
@@ -230,7 +218,6 @@ static const struct tty_operations bfin_jc_ops = { 
	.flush_chars     = bfin_jc_flush_chars,

	.write_room      = bfin_jc_write_room,

	.chars_in_buffer = bfin_jc_chars_in_buffer,

	.wait_until_sent = bfin_jc_wait_until_sent,

};



static int __init bfin_jc_init(void)