Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6ae833c7 authored by Tejun Heo's avatar Tejun Heo
Browse files

percpu: fix how @gfp is interpreted by the percpu allocator 



When @gfp is specified, the percpu allocator is interested in whether
it contains all of GFP_KERNEL or not.  If it does, the normal
allocation path is taken; otherwise, the atomic allocation path.
Unfortunately, pcpu_alloc() was incorrectly testing for whether @gfp
contains any part of GFP_KERNEL.

Fix it by testing "(gfp & GFP_KERNEL) != GFP_KERNEL" instead of
"!(gfp & GFP_KERNEL)" to decide whether the allocation should be
atomic or not.

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 17497acb

mm/percpu.c

+1 −1
Original line number Diff line number Diff line
@@ -876,7 +876,7 @@ static void __percpu *pcpu_alloc(size_t size, size_t align, bool reserved, 
	static int warn_limit = 10;

	struct pcpu_chunk *chunk;

	const char *err;

	bool is_atomic = !(gfp & GFP_KERNEL);

	bool is_atomic = (gfp & GFP_KERNEL) != GFP_KERNEL;

	int occ_pages = 0;

	int slot, off, new_alloc, cpu, ret;

	unsigned long flags;