Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6a73336b authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

PCI: Remove "no hotplug settings from platform" warning 

We print way too many messages like this:

    pci 0000:00:00.0: no hotplug settings from platform
    pci 0000:00:00.0: using default PCI settings

This usually happens when the platform doesn't supply an ACPI _HPP method,
but the method is optional, so there's no point in warning about it.

Not only are the messages useless, but we call pci_configure_slot() far too
many times, so they're repeated many times.  I'll fix the overuse of
pci_configure_slot() too, but that will wait until the next merge window.

For now, just remove both log messages.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=84391


Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarYinghai Lu <yinghai@kernel.org>
parent 52addcf9

drivers/pci/hotplug/pcihp_slot.c

+1 −5
Original line number Diff line number Diff line
@@ -46,7 +46,6 @@ static void program_hpp_type0(struct pci_dev *dev, struct hpp_type0 *hpp) 
		 */

		if (pci_is_pcie(dev))

			return;

		dev_info(&dev->dev, "using default PCI settings\n");

		hpp = &pci_default_type0;

	}
@@ -153,7 +152,6 @@ void pci_configure_slot(struct pci_dev *dev) 
{

	struct pci_dev *cdev;

	struct hotplug_params hpp;

	int ret;



	if (!(dev->hdr_type == PCI_HEADER_TYPE_NORMAL ||

			(dev->hdr_type == PCI_HEADER_TYPE_BRIDGE &&
@@ -163,9 +161,7 @@ void pci_configure_slot(struct pci_dev *dev) 
	pcie_bus_configure_settings(dev->bus);



	memset(&hpp, 0, sizeof(hpp));

	ret = pci_get_hp_params(dev, &hpp);

	if (ret)

		dev_warn(&dev->dev, "no hotplug settings from platform\n");

	pci_get_hp_params(dev, &hpp);



	program_hpp_type2(dev, hpp.t2);

	program_hpp_type1(dev, hpp.t1);