Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 69e7dae4 authored by Paul Gortmaker's avatar Paul Gortmaker
Browse files

ip_vs.h: fix implicit use of module_get/module_put from module.h 



This file was using the module get/put functions in two simple inline
functions.  But module_get/put were only within scope because of
the implicit presence of module.h being everywhere.

Rather than add module.h to another file in include/  -- which is
exactly the thing we are trying to avoid, simply convert these
one-line functions into a define, as per what was done for the
device_schedule_callback() in commit 523ded71.

Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
parent 34641c6d

include/net/ip_vs.h

+7 −8
Original line number Original line Diff line number Diff line
@@ -1126,17 +1126,16 @@ int unregister_ip_vs_pe(struct ip_vs_pe *pe); 
struct ip_vs_pe *ip_vs_pe_getbyname(const char *name);

struct ip_vs_pe *ip_vs_pe_getbyname(const char *name);

struct ip_vs_pe *__ip_vs_pe_getbyname(const char *pe_name);

struct ip_vs_pe *__ip_vs_pe_getbyname(const char *pe_name);





static inline void ip_vs_pe_get(const struct ip_vs_pe *pe)

/*

{

 * Use a #define to avoid all of module.h just for these trivial ops

	if (pe && pe->module)

 */

#define ip_vs_pe_get(pe)			\

	if (pe && pe->module)			\

		__module_get(pe->module);

		__module_get(pe->module);

}





static inline void ip_vs_pe_put(const struct ip_vs_pe *pe)

#define ip_vs_pe_put(pe)			\

{

	if (pe && pe->module)			\

	if (pe && pe->module)

		module_put(pe->module);

		module_put(pe->module);

}





/*

/*

 *	IPVS protocol functions (from ip_vs_proto.c)

 *	IPVS protocol functions (from ip_vs_proto.c)