Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 698e96a8 authored by Volker Lendecke's avatar Volker Lendecke Committed by Steve French
Browse files

Streamline SendReceiveBlockingLock: Use "goto out:" in an error condition 



Streamline SendReceiveBlockingLock: Use "goto out:" in an error condition

Signed-off-by: default avatarVolker Lendecke <vl@samba.org>
Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
parent 17c8bfed

fs/cifs/transport.c

+31 −30
Original line number Diff line number Diff line
@@ -1067,8 +1067,13 @@ SendReceiveBlockingLock(const unsigned int xid, struct cifsTconInfo *tcon, 


	/* rcvd frame is ok */



	if (midQ->resp_buf && out_buf

	    && (midQ->midState == MID_RESPONSE_RECEIVED)) {

	if ((midQ->resp_buf == NULL) || (out_buf == NULL)

	    || (midQ->midState != MID_RESPONSE_RECEIVED)) {

		rc = -EIO;

		cERROR(1, ("Bad MID state?"));

		goto out;

	}



	out_buf->smb_buf_length = receive_len;

	memcpy((char *)out_buf + 4,

	       (char *)midQ->resp_buf + 4,
@@ -1098,10 +1103,6 @@ SendReceiveBlockingLock(const unsigned int xid, struct cifsTconInfo *tcon, 
	    /* do not count RFC1001 header */  +

	    (2 * out_buf->WordCount) + 2 /* bcc */ )

		BCC(out_buf) = le16_to_cpu(BCC_LE(out_buf));

	} else {

		rc = -EIO;

		cERROR(1, ("Bad MID state?"));

	}



out:

	DeleteMidQEntry(midQ);