Commit 688ec344 authored Mar 27, 2012 by Axel Lin Committed by Florian Tobias Schandinat Apr 09, 2012

video: pxa3xx-gcu: Simplify the logic to exit while loop in pxa3xx_gcu_wait_idle



If wait_event_interruptible_timeout returns a positive value, it means
the condition evaluated is true. Which means priv->shared->hw_running is false.
And then we will exit the loop.

This patch simplifies the logic to exit the while loop.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>

parent 79d3c41a

drivers/video/pxa3xx-gcu.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -316,12 +316,9 @@ pxa3xx_gcu_wait_idle(struct pxa3xx_gcu_priv *priv)
		ret = wait_event_interruptible_timeout(priv->wait_idle,
		!priv->shared->hw_running, HZ*4);

		if (ret < 0)
		if (ret != 0)
		break;

		if (ret > 0)
		continue;

		if (gc_readl(priv, REG_GCRBEXHR) == rbexhr &&
		priv->shared->num_interrupts == num) {
		QERROR("TIMEOUT");