Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 681587c5 authored by Roel Kluin's avatar Roel Kluin Committed by Russell King
Browse files

[ARM] serial: s3c2410: platform_get_irq() may return signed unnoticed 



port->irq is unsigned, platform_get_irq() may return signed unnoticed

Signed-off-by: default avatarRoel Kluin <12o3l@tiscali.nl>
Acked-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent 62783679

drivers/serial/s3c2410.c

+5 −2
Original line number Diff line number Diff line
@@ -1022,6 +1022,7 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport, 
	struct uart_port *port = &ourport->port;

	struct s3c2410_uartcfg *cfg;

	struct resource *res;

	int ret;



	dbg("s3c24xx_serial_init_port: port=%p, platdev=%p\n", port, platdev);
@@ -1064,9 +1065,11 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport, 


	port->mapbase	= res->start;

	port->membase	= S3C24XX_VA_UART + (res->start - S3C24XX_PA_UART);

	port->irq	= platform_get_irq(platdev, 0);

	if (port->irq < 0)

	ret = platform_get_irq(platdev, 0);

	if (ret < 0)

		port->irq = 0;

	else

		port->irq = ret;



	ourport->clk	= clk_get(&platdev->dev, "uart");