hwmon: (atxp1) Set and use error code from vid_to_reg() (674d0ed8) · Commits · e / devices / android_kernel_teracube_2e

vid_to_reg() returns -1 if it encounters an error. Return -EINVAL instead. Its only caller, atxp1_storevcore(), doesn't use the return code but returns -1 instead, which is wrong anyway as it means -EPERM. Use the return value from vid_to_reg() instead to report the error. Signed-off-by:

Guenter Roeck <linux@roeck-us.net> Reviewed-by:

Jean Delvare <khali@linux-fr.org>

drivers/hwmon/atxp1.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -147,10 +147,9 @@ static ssize_t atxp1_storevcore(struct device *dev,

		/* Calculate VID */
		vid = vid_to_reg(vcore, data->vrm);

		if (vid < 0) {
		dev_err(dev, "VID calculation failed.\n");
		return -1;
		return vid;
		}

		/*

include/linux/hwmon-vid.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -38,7 +38,7 @@ static inline int vid_to_reg(int val, u8 vrm)
		return ((val >= 1100) && (val <= 1850) ?
		((18499 - val * 10) / 25 + 5) / 10 : -1);
		default:
		return -1;
		return -EINVAL;
		}
		}