Commit 67059406 authored Jul 31, 2009 by Bartlomiej Zolnierkiewicz Committed by Len Brown Aug 28, 2009

fujitsu-laptop: remove superfluous NULL pointer checks



This takes care of the following entries from Dan's list:

drivers/platform/x86/fujitsu-laptop.c +327 set_lcd_level(13) warning:
variable derefenced before check 'fujitsu'
drivers/platform/x86/fujitsu-laptop.c +358 set_lcd_level_alt(13) warning:
variable derefenced before check 'fujitsu'

Reported-by: Dan Carpenter <error27@gmail.com>
Cc: corbet@lwn.net
Cc: eteo@redhat.com
Cc: Julia Lawall <julia@diku.dk>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>
Signed-off-by: Len Brown <len.brown@intel.com>

parent 14485c57

drivers/platform/x86/fujitsu-laptop.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -324,9 +324,6 @@ static int set_lcd_level(int level)
		if (level < 0 \|\| level >= fujitsu->max_brightness)
		return -EINVAL;

		if (!fujitsu)
		return -EINVAL;

		status = acpi_get_handle(fujitsu->acpi_handle, "SBLL", &handle);
		if (ACPI_FAILURE(status)) {
		vdbg_printk(FUJLAPTOP_DBG_ERROR, "SBLL not present\n");
		@@ -355,9 +352,6 @@ static int set_lcd_level_alt(int level)
		if (level < 0 \|\| level >= fujitsu->max_brightness)
		return -EINVAL;

		if (!fujitsu)
		return -EINVAL;

		status = acpi_get_handle(fujitsu->acpi_handle, "SBL2", &handle);
		if (ACPI_FAILURE(status)) {
		vdbg_printk(FUJLAPTOP_DBG_ERROR, "SBL2 not present\n");