Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 66f5ce25 authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Stephen Boyd
Browse files

clk: qcom: common: check for failure 



We were not checking the return from devm_add_action() which can fail.
Start using the helper and devm_add_action_or_reset() and return
directly as we know that the cleanup has been done by this helper.

Signed-off-by: default avatarSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
parent a3499e9b

drivers/clk/qcom/common.c

+11 −6
Original line number Diff line number Diff line
@@ -213,7 +213,11 @@ int qcom_cc_really_probe(struct platform_device *pdev, 
	if (ret)

		return ret;



	devm_add_action(dev, qcom_cc_del_clk_provider, pdev->dev.of_node);

	ret = devm_add_action_or_reset(dev, qcom_cc_del_clk_provider,

				       pdev->dev.of_node);



	if (ret)

		return ret;



	reset = &cc->reset;

	reset->rcdev.of_node = dev->of_node;
@@ -227,7 +231,11 @@ int qcom_cc_really_probe(struct platform_device *pdev, 
	if (ret)

		return ret;



	devm_add_action(dev, qcom_cc_reset_unregister, &reset->rcdev);

	ret = devm_add_action_or_reset(dev, qcom_cc_reset_unregister,

				       &reset->rcdev);



	if (ret)

		return ret;



	if (desc->gdscs && desc->num_gdscs) {

		ret = gdsc_register(dev, desc->gdscs, desc->num_gdscs,
@@ -236,10 +244,7 @@ int qcom_cc_really_probe(struct platform_device *pdev, 
			return ret;

	}



	devm_add_action(dev, qcom_cc_gdsc_unregister, dev);





	return 0;

	return devm_add_action_or_reset(dev, qcom_cc_gdsc_unregister, dev);

}

EXPORT_SYMBOL_GPL(qcom_cc_really_probe);