Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 66c8684a authored by Andreas Herrmann's avatar Andreas Herrmann Committed by James Bottomley
Browse files

[SCSI] zfcp: fix wrong handling of failed requests for GID_PN command 



Fixes the handling of failed requests for GID_PN nameserver command:
Set ZFCP_STATUS_PORT_INVALID_WWPN only if indicated by response
payload for GID_PN nameserver command and not if fsf request fails.

Signed-off-by: default avatarAndreas Herrmann <aherrman@de.ibm.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent d6cbbad7

drivers/s390/scsi/zfcp_aux.c

+4 −1
Original line number Diff line number Diff line
@@ -1753,7 +1753,10 @@ static void zfcp_ns_gid_pn_handler(unsigned long data) 
	ct_iu_req = zfcp_sg_to_address(ct->req);

	ct_iu_resp = zfcp_sg_to_address(ct->resp);



	if ((ct->status != 0) || zfcp_check_ct_response(&ct_iu_resp->header)) {

	if (ct->status != 0)

		goto failed;



	if (zfcp_check_ct_response(&ct_iu_resp->header)) {

		/* FIXME: do we need some specific erp entry points */

		atomic_set_mask(ZFCP_STATUS_PORT_INVALID_WWPN, &port->status);

		goto failed;