Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 651701d7 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Alex Elder
Browse files

xfs: remove incorrect log write optimization 



We do need a barrier for the first buffer of a split log write.
Otherwise we might incorrectly stamp the tail LSN into transactions
in the first part of the split write, or not flush data I/O before
updating the inode size.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAlex Elder <aelder@sgi.com>
parent 2727ccc9

fs/xfs/xfs_log.c

+2 −5
Original line number Original line Diff line number Diff line
@@ -1423,11 +1423,8 @@ xlog_sync(xlog_t *log, 
	XFS_BUF_BUSY(bp);

	XFS_BUF_BUSY(bp);

	XFS_BUF_ASYNC(bp);

	XFS_BUF_ASYNC(bp);

	bp->b_flags |= XBF_LOG_BUFFER;

	bp->b_flags |= XBF_LOG_BUFFER;

	/*



	 * Do an ordered write for the log block.

	if (log->l_mp->m_flags & XFS_MOUNT_BARRIER)

	 * Its unnecessary to flush the first split block in the log wrap case.

	 */

	if (!split && (log->l_mp->m_flags & XFS_MOUNT_BARRIER))

		XFS_BUF_ORDERED(bp);

		XFS_BUF_ORDERED(bp);





	ASSERT(XFS_BUF_ADDR(bp) <= log->l_logBBsize-1);

	ASSERT(XFS_BUF_ADDR(bp) <= log->l_logBBsize-1);