Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 648e42e1 authored by Barry Song's avatar Barry Song Committed by Linus Walleij
Browse files

pinctrl: sirf: fix typo for GPIO bank number 



The patch 7420d2d0: "pinctrl: sirf: switch driver to use gpiolib
irqchip helpers" from Apr 15, 2014, leads to the following static
checker warning:

      drivers/pinctrl/sirf/pinctrl-sirf.c:578 sirfsoc_gpio_handle_irq()
      warn: buffer overflow 'sgpio_chip.sgpio_bank' 5 <= 31

Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarBarry Song <Baohua.Song@csr.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent de5af04e

drivers/pinctrl/sirf/pinctrl-sirf.c

+2 −2
Original line number Diff line number Diff line
@@ -574,12 +574,12 @@ static void sirfsoc_gpio_handle_irq(unsigned int irq, struct irq_desc *desc) 
	struct irq_chip *chip = irq_get_chip(irq);

	int i;



	for (i = 0; i < SIRFSOC_GPIO_BANK_SIZE; i++) {

	for (i = 0; i < SIRFSOC_GPIO_NO_OF_BANKS; i++) {

		bank = &sgpio_chip.sgpio_bank[i];

		if (bank->parent_irq == irq)

			break;

	}

	BUG_ON (i == SIRFSOC_GPIO_BANK_SIZE);

	BUG_ON(i == SIRFSOC_GPIO_NO_OF_BANKS);



	chained_irq_enter(chip, desc);