Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 63e24c49 authored by Markus Elfring's avatar Markus Elfring Committed by Casey Schaufler
Browse files

Smack: Use memdup_user() rather than duplicating its implementation 



Reuse existing functionality from memdup_user() instead of keeping
duplicate source code.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Acked-by: default avatarCasey Schaufler <casey@schaufler-ca.com>
parent 29b4817d

security/smack/smackfs.c

+3 −8
Original line number Diff line number Diff line
@@ -2523,14 +2523,9 @@ static ssize_t smk_write_revoke_subj(struct file *file, const char __user *buf, 
	if (count == 0 || count > SMK_LONGLABEL)

		return -EINVAL;



	data = kzalloc(count, GFP_KERNEL);

	if (data == NULL)

		return -ENOMEM;



	if (copy_from_user(data, buf, count) != 0) {

		rc = -EFAULT;

		goto out_data;

	}

	data = memdup_user(buf, count);

	if (IS_ERR(data))

		return PTR_ERR(data);



	cp = smk_parse_smack(data, count);

	if (IS_ERR(cp)) {