Commit 63c8a58d authored Jun 24, 2011 by Axel Lin Committed by Samuel Ortiz Jul 31, 2011

mfd: Fix off-by-one value range checking for tps65912_i2c_write



If bytes == (TPS6591X_MAX_REGISTER + 1), we have a buffer overflow when
doing memcpy(&msg[1], src, bytes).

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>

parent a5e06781

drivers/mfd/tps65912-i2c.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -57,7 +57,7 @@ static int tps65912_i2c_write(struct tps65912 *tps65912, u8 reg,
		u8 msg[TPS6591X_MAX_REGISTER + 1];
		int ret;

		if (bytes > (TPS6591X_MAX_REGISTER + 1))
		if (bytes > TPS6591X_MAX_REGISTER)
		return -EINVAL;

		msg[0] = reg;