Commit 627fdfac authored Nov 01, 2018 by Dan Carpenter Committed by Greg Kroah-Hartman Jan 13, 2019

scsi: bnx2fc: Fix NULL dereference in error handling



[ Upstream commit 9ae4f8420ed7be4b13c96600e3568c144d101a23 ]

If "interface" is NULL then we can't release it and trying to will only
lead to an Oops.

Fixes: aea71a02 ("[SCSI] bnx2fc: Introduce interface structure for each vlan interface")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent d013a1cd

drivers/scsi/bnx2fc/bnx2fc_fcoe.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -2331,7 +2331,7 @@ static int _bnx2fc_create(struct net_device *netdev,
	if (!interface) {		if (!interface) {
	printk(KERN_ERR PFX "bnx2fc_interface_create failed\n");		printk(KERN_ERR PFX "bnx2fc_interface_create failed\n");
	rc = -ENOMEM;		rc = -ENOMEM;
	goto ifput_err;		goto netdev_err;
	}		}

	if (netdev->priv_flags & IFF_802_1Q_VLAN) {		if (netdev->priv_flags & IFF_802_1Q_VLAN) {