Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 61faddf6 authored by Stefan Seyfried's avatar Stefan Seyfried Committed by Gustavo Padovan
Browse files

Bluetooth: Fix log spamming in btusb due to autosuspend



If a device is autosuspended an inability to resubmit URBs is
to be expected. Check the error code and only log real errors.
(Now that autosuspend is default enabled for btusb, those log
messages were happening all the time e.g. with a BT mouse)

Signed-off-by: default avatarStefan Seyfried <seife+kernel@b1-systems.com>
Signed-off-by: default avatarOliver Neukum <oneukum@suse.de>
Acked-by: default avatarMarcel Holtmann <marcel@holtmann.org>
Signed-off-by: default avatarGustavo F. Padovan <padovan@profusion.mobi>
parent c89ad737
Loading
Loading
Loading
Loading
+6 −3
Original line number Original line Diff line number Diff line
@@ -239,6 +239,7 @@ static void btusb_intr_complete(struct urb *urb)


	err = usb_submit_urb(urb, GFP_ATOMIC);
	err = usb_submit_urb(urb, GFP_ATOMIC);
	if (err < 0) {
	if (err < 0) {
		if (err != -EPERM)
			BT_ERR("%s urb %p failed to resubmit (%d)",
			BT_ERR("%s urb %p failed to resubmit (%d)",
						hdev->name, urb, -err);
						hdev->name, urb, -err);
		usb_unanchor_urb(urb);
		usb_unanchor_urb(urb);
@@ -323,6 +324,7 @@ static void btusb_bulk_complete(struct urb *urb)


	err = usb_submit_urb(urb, GFP_ATOMIC);
	err = usb_submit_urb(urb, GFP_ATOMIC);
	if (err < 0) {
	if (err < 0) {
		if (err != -EPERM)
			BT_ERR("%s urb %p failed to resubmit (%d)",
			BT_ERR("%s urb %p failed to resubmit (%d)",
						hdev->name, urb, -err);
						hdev->name, urb, -err);
		usb_unanchor_urb(urb);
		usb_unanchor_urb(urb);
@@ -412,6 +414,7 @@ static void btusb_isoc_complete(struct urb *urb)


	err = usb_submit_urb(urb, GFP_ATOMIC);
	err = usb_submit_urb(urb, GFP_ATOMIC);
	if (err < 0) {
	if (err < 0) {
		if (err != -EPERM)
			BT_ERR("%s urb %p failed to resubmit (%d)",
			BT_ERR("%s urb %p failed to resubmit (%d)",
						hdev->name, urb, -err);
						hdev->name, urb, -err);
		usb_unanchor_urb(urb);
		usb_unanchor_urb(urb);