Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5fe1b76a authored by Joe Perches's avatar Joe Perches Committed by John W. Linville
Browse files

rsi: Add pr_fmt,__printf, fix format & arg mismatch



Emit a prefix for the rsi_dbg messages.

Fix the format and argument mismatch and add
__printf(2, 3) to try to avoid more.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 8ace189d
Loading
Loading
Loading
Loading
+2 −0
Original line number Diff line number Diff line
@@ -14,6 +14,8 @@
 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 */

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

#include <linux/module.h>
#include <linux/firmware.h>
#include "rsi_mgmt.h"
+2 −1
Original line number Diff line number Diff line
@@ -393,7 +393,8 @@ static int rsi_mgmt_pkt_to_core(struct rsi_common *common,

		msg_len -= pad_bytes;
		if ((msg_len <= 0) || (!msg)) {
			rsi_dbg(MGMT_RX_ZONE, "Invalid rx msg of len = %d\n",
			rsi_dbg(MGMT_RX_ZONE,
				"%s: Invalid rx msg of len = %d\n",
				__func__, msg_len);
			return -EINVAL;
		}
+1 −1
Original line number Diff line number Diff line
@@ -40,7 +40,7 @@
#define FSM_MAC_INIT_DONE               6

extern u32 rsi_zone_enabled;
extern void rsi_dbg(u32 zone, const char *fmt, ...);
extern __printf(2, 3) void rsi_dbg(u32 zone, const char *fmt, ...);

#define RSI_MAX_VIFS                    1
#define NUM_EDCA_QUEUES                 4