Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5fb5e41f authored by Michal Kazior's avatar Michal Kazior Committed by Kalle Valo
Browse files

ath10k: plug memory leak in wmi mgmt tx worker 



sk_buff was not freed in some cases. The patch
unifies the msdu freeing.

Signed-off-by: default avatarMichal Kazior <michal.kazior@tieto.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent 5474efe8

drivers/net/wireless/ath/ath10k/mac.c

+3 −1
Original line number Diff line number Diff line
@@ -1729,8 +1729,10 @@ void ath10k_mgmt_over_wmi_tx_work(struct work_struct *work) 
			break;



		ret = ath10k_wmi_mgmt_tx(ar, skb);

		if (ret)

		if (ret) {

			ath10k_warn("wmi mgmt_tx failed (%d)\n", ret);

			ieee80211_free_txskb(ar->hw, skb);

		}

	}

}

drivers/net/wireless/ath/ath10k/wmi.c

+1 −3
Original line number Diff line number Diff line
@@ -674,10 +674,8 @@ int ath10k_wmi_mgmt_tx(struct ath10k *ar, struct sk_buff *skb) 


	/* Send the management frame buffer to the target */

	ret = ath10k_wmi_cmd_send(ar, wmi_skb, ar->wmi.cmd->mgmt_tx_cmdid);

	if (ret) {

		dev_kfree_skb_any(skb);

	if (ret)

		return ret;

	}



	/* TODO: report tx status to mac80211 - temporary just ACK */

	info->flags |= IEEE80211_TX_STAT_ACK;