Commit 5f786595 authored Jul 19, 2014 by Himangi Saraogi Committed by Richard Weinberger Oct 13, 2014

um: net: Eliminate NULL test after alloc_bootmem



alloc_bootmem and related functions never return NULL. Thus a NULL
test or memset after calls to these functions is unnecessary.

The following Coccinelle semantic patch was used for making the change:

@@
expression E;
statement S;
@@

E = \(alloc_bootmem\|alloc_bootmem_low\|alloc_bootmem_pages\|alloc_bootmem_low_pages\)(...)
... when != E
- if (E == NULL) S

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Richard Weinberger <richard@nod.at>

parent 970e51fe

arch/um/drivers/net_kern.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -659,10 +659,6 @@ static int __init eth_setup(char *str)
		}

		new = alloc_bootmem(sizeof(*new));
		if (new == NULL) {
		printk(KERN_ERR "eth_init : alloc_bootmem failed\n");
		return 1;
		}

		INIT_LIST_HEAD(&new->list);
		new->index = n;