Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5e2b8828 authored by Miklos Szeredi's avatar Miklos Szeredi
Browse files

fuse: invalidate dir dentry after chmod 



Without "default_permissions" the userspace filesystem's lookup operation
needs to perform the check for search permission on the directory.

If directory does not allow search for everyone (this is quite rare) then
userspace filesystem has to set entry timeout to zero to make sure
permissions are always performed.

Changing the mode bits of the directory should also invalidate the
(previously cached) dentry to make sure the next lookup will have a chance
of updating the timeout, if needed.

Reported-by: default avatarJean-Pierre André <jean-pierre.andre@wanadoo.fr>
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
Cc: <stable@vger.kernel.org>
parent 703c7362

fs/fuse/dir.c

+10 −2
Original line number Diff line number Diff line
@@ -1703,14 +1703,22 @@ int fuse_do_setattr(struct inode *inode, struct iattr *attr, 
static int fuse_setattr(struct dentry *entry, struct iattr *attr)

{

	struct inode *inode = d_inode(entry);

	int ret;



	if (!fuse_allow_current_process(get_fuse_conn(inode)))

		return -EACCES;



	if (attr->ia_valid & ATTR_FILE)

		return fuse_do_setattr(inode, attr, attr->ia_file);

		ret = fuse_do_setattr(inode, attr, attr->ia_file);

	else

		return fuse_do_setattr(inode, attr, NULL);

		ret = fuse_do_setattr(inode, attr, NULL);



	if (!ret) {

		/* Directory mode changed, may need to revalidate access */

		if (d_is_dir(entry) && (attr->ia_valid & ATTR_MODE))

			fuse_invalidate_entry_cache(entry);

	}

	return ret;

}



static int fuse_getattr(struct vfsmount *mnt, struct dentry *entry,