Commit 5d8be843 authored Jul 10, 2013 by Mikulas Patocka Committed by Alasdair G Kergon Jul 10, 2013

dm verity: remove pointless comparison



Remove num < 0 test in verity_ctr because num is unsigned.
(Found by Coverity.)

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>

parent 220cd058

drivers/md/dm-verity.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -695,8 +695,8 @@ static int verity_ctr(struct dm_target ti, unsigned argc, char *argv)
		goto bad;
		}

		if (sscanf(argv[0], "%d%c", &num, &dummy) != 1 \|\|
		num < 0 \|\| num > 1) {
		if (sscanf(argv[0], "%u%c", &num, &dummy) != 1 \|\|
		num > 1) {
		ti->error = "Invalid version";
		r = -EINVAL;
		goto bad;