Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ce59ae0 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: Add check for kcalloc argument order 



kcalloc is sometimes misused with the first and second arguments switched.

Same issue with kmalloc_array too.

Bleat if sizeof is the first argument

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent e8eb3997

scripts/checkpatch.pl

+6 −0
Original line number Diff line number Diff line
@@ -3476,6 +3476,12 @@ sub process { 
			     "unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);

		}



# check for alloc argument mismatch

		if ($line =~ /\b(kcalloc|kmalloc_array)\s*\(\s*sizeof\b/) {

			WARN("ALLOC_ARRAY_ARGS",

			     "$1 uses number as first arg, sizeof is generally wrong\n" . $herecurr);

		}



# check for multiple semicolons

		if ($line =~ /;\s*;\s*$/) {

			WARN("ONE_SEMICOLON",