Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5c240fa2 authored Aug 22, 2015 by santosh.shilimkar@oracle.com Committed by David S. Miller Aug 25, 2015

RDS: Fix assertion level from fatal to warning



Fix the asserion level since its not fatal and can be hit
in normal execution paths. There is no need to take the
system down.

We keep the WARN_ON() to detect the condition if we get
here with bad pages.

Reviewed-by: Ajaykumar Hotchandani <ajaykumar.hotchandani@oracle.com>
Signed-off-by: Santosh Shilimkar <ssantosh@kernel.org>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 3049147c

net/rds/ib_rdma.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -490,7 +490,7 @@ static void __rds_ib_teardown_mr(struct rds_ib_mr *ibmr)

		/* FIXME we need a way to tell a r/w MR
		* from a r/o MR */
		BUG_ON(irqs_disabled());
		WARN_ON(!page->mapping && irqs_disabled());
		set_page_dirty(page);
		put_page(page);
		}

net/rds/rdma.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -451,7 +451,7 @@ void rds_rdma_free_op(struct rm_rdma_op *ro)
		* is the case for a RDMA_READ which copies from remote
		* to local memory */
		if (!ro->op_write) {
		BUG_ON(irqs_disabled());
		WARN_ON(!page->mapping && irqs_disabled());
		set_page_dirty(page);
		}
		put_page(page);