Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ad5be58 authored by Mark Einon's avatar Mark Einon Committed by Greg Kroah-Hartman
Browse files

staging: et131x: Remove redundant et131x_reset_recv() call 



This call doesn't do anything useful - only warns on the receive list
being empty, so removed it.

Signed-off-by: default avatarMark Einon <mark.einon@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 16d8de3c

drivers/staging/et131x/et131x.c

+0 −18
Original line number Diff line number Diff line
@@ -605,7 +605,6 @@ int32_t et131x_mii_write(struct et131x_adapter *adapter, 
void et131x_rx_dma_memory_free(struct et131x_adapter *adapter);

void et131x_rx_dma_disable(struct et131x_adapter *adapter);

void et131x_rx_dma_enable(struct et131x_adapter *adapter);

void et131x_reset_recv(struct et131x_adapter *adapter);

void et131x_init_send(struct et131x_adapter *adapter);

void et131x_tx_dma_enable(struct et131x_adapter *adapter);
@@ -1839,9 +1838,6 @@ void et1310_disable_phy_coma(struct et131x_adapter *adapter) 
	/* Re-initialize the send structures */

	et131x_init_send(adapter);



	/* Reset the RFD list and re-start RU  */

	et131x_reset_recv(adapter);



	/* Bring the device back to the state it was during init prior to

	 * autonegotiation being complete.  This way, when we get the auto-neg

	 * complete interrupt, we can complete init by calling ConfigMacREGS2.
@@ -2881,17 +2877,6 @@ static struct rfd *nic_rx_pkts(struct et131x_adapter *adapter) 
	return rfd;

}



/**

 * et131x_reset_recv - Reset the receive list

 * @adapter: pointer to our adapter

 *

 * Assumption, Rcv spinlock has been acquired.

 */

void et131x_reset_recv(struct et131x_adapter *adapter)

{

	WARN_ON(list_empty(&adapter->rx_ring.recv_list));

}



/**

 * et131x_handle_recv_interrupt - Interrupt handler for receive processing

 * @adapter: pointer to our adapter
@@ -4251,9 +4236,6 @@ static void et131x_adjust_link(struct net_device *netdev) 
			/* Re-initialize the send structures */

			et131x_init_send(adapter);



			/* Reset the RFD list and re-start RU */

			et131x_reset_recv(adapter);



			/*

			 * Bring the device back to the state it was during

			 * init prior to autonegotiation being complete. This