Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5a501b30 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

Staging: rt2870: disable root hack for reading files 



We are now using credentials, so just blindly setting the fsuid and
fsguid isn't acceptable.  All this means is that the config file needs
to be readable by the driver thread, not a big deal.

Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent c55519ff

drivers/staging/rt2870/rt_profile.c

+7 −3
Original line number Diff line number Diff line
@@ -925,9 +925,11 @@ NDIS_STATUS RTMPReadParametersHook( 


	// Save uid and gid used for filesystem access.

	// Set user and group to 0 (root)

	orgfsuid = current->fsuid;

	orgfsgid = current->fsgid;

	current->fsuid=current->fsgid = 0;

	orgfsuid = current_fsuid();

	orgfsgid = current_fsgid();

	/* Hm, can't really do this nicely anymore, so rely on these files

	 * being set to the proper permission to read them... */

	/* current->cred->fsuid = current->cred->fsgid = 0; */

    orgfs = get_fs();

    set_fs(KERNEL_DS);
@@ -1590,8 +1592,10 @@ NDIS_STATUS RTMPReadParametersHook( 
	}



	set_fs(orgfs);

#if 0

	current->fsuid = orgfsuid;

	current->fsgid = orgfsgid;

#endif



	kfree(buffer);

	kfree(tmpbuf);