Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5a36b68b authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

usbnet: smsc95xx: silence an uninitialized variable warning 



If the call to fn() fails then "buf" is uninitialized.  Just return the
error code in that case.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 58ef6a3f

drivers/net/usb/smsc95xx.c

+3 −1
Original line number Diff line number Diff line
@@ -92,9 +92,11 @@ static int __must_check __smsc95xx_read_reg(struct usbnet *dev, u32 index, 
	ret = fn(dev, USB_VENDOR_REQUEST_READ_REGISTER, USB_DIR_IN

		 | USB_TYPE_VENDOR | USB_RECIP_DEVICE,

		 0, index, &buf, 4);

	if (unlikely(ret < 0))

	if (unlikely(ret < 0)) {

		netdev_warn(dev->net, "Failed to read reg index 0x%08x: %d\n",

			    index, ret);

		return ret;

	}



	le32_to_cpus(&buf);

	*data = buf;