Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 59d6a29e authored by Samuel Iglesias Gonsalvez's avatar Samuel Iglesias Gonsalvez Committed by Greg Kroah-Hartman
Browse files

Staging: ipack/devices/ipoctal: remove unneeded lock in IRQ handler 



In the rest of the code, the data is protected with spin_lock_irqsave().

Signed-off-by: default avatarSamuel Iglesias Gonsalvez <siglesias@igalia.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bae8bd16

drivers/staging/ipack/devices/ipoctal.c

+1 −2
Original line number Diff line number Diff line
@@ -299,7 +299,7 @@ static int ipoctal_irq_handler(void *arg) 
				ipoctal->nb_bytes[channel] = 0;

				continue;

			}

			spin_lock(&ipoctal->lock[channel]);



			value = ipoctal->tty_port[channel].xmit_buf[*pointer_write];

			ipoctal_write_io_reg(ipoctal,

					     &ipoctal->chan_regs[channel].u.w.thr,
@@ -309,7 +309,6 @@ static int ipoctal_irq_handler(void *arg) 
			(*pointer_write)++;

			*pointer_write = *pointer_write % PAGE_SIZE;

			ipoctal->nb_bytes[channel]--;

			spin_unlock(&ipoctal->lock[channel]);



			if ((ipoctal->nb_bytes[channel] == 0) &&

			    (waitqueue_active(&ipoctal->queue[channel]))) {