Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 59430c2f authored by Linus Torvalds's avatar Linus Torvalds
Browse files
* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6:
  tc: Fix unitialized kernel memory leak
  pkt_sched: Revert tasklet_hrtimer changes.
  net: sk_free() should be allowed right after sk_alloc()
  gianfar: gfar_remove needs to call unregister_netdev()
  ipw2200: firmware DMA loading rework
parents e9ee3a54 16ebb5e0
Loading
Loading
Loading
Loading
+1 −0
Original line number Original line Diff line number Diff line
@@ -491,6 +491,7 @@ static int gfar_remove(struct of_device *ofdev)


	dev_set_drvdata(&ofdev->dev, NULL);
	dev_set_drvdata(&ofdev->dev, NULL);


	unregister_netdev(dev);
	iounmap(priv->regs);
	iounmap(priv->regs);
	free_netdev(priv->ndev);
	free_netdev(priv->ndev);


+67 −53
Original line number Original line Diff line number Diff line
@@ -2874,45 +2874,27 @@ static int ipw_fw_dma_add_command_block(struct ipw_priv *priv,
	return 0;
	return 0;
}
}


static int ipw_fw_dma_add_buffer(struct ipw_priv *priv,
static int ipw_fw_dma_add_buffer(struct ipw_priv *priv, dma_addr_t *src_address,
				 u32 src_phys, u32 dest_address, u32 length)
				 int nr, u32 dest_address, u32 len)
{
{
	u32 bytes_left = length;
	int ret, i;
	u32 src_offset = 0;
	u32 size;
	u32 dest_offset = 0;

	int status = 0;
	IPW_DEBUG_FW(">> \n");
	IPW_DEBUG_FW(">> \n");
	IPW_DEBUG_FW_INFO("src_phys=0x%x dest_address=0x%x length=0x%x\n",
	IPW_DEBUG_FW_INFO("nr=%d dest_address=0x%x len=0x%x\n",
			  src_phys, dest_address, length);
			  nr, dest_address, len);
	while (bytes_left > CB_MAX_LENGTH) {

		status = ipw_fw_dma_add_command_block(priv,
	for (i = 0; i < nr; i++) {
						      src_phys + src_offset,
		size = min_t(u32, len - i * CB_MAX_LENGTH, CB_MAX_LENGTH);
		ret = ipw_fw_dma_add_command_block(priv, src_address[i],
						   dest_address +
						   dest_address +
						      dest_offset,
						   i * CB_MAX_LENGTH, size,
						      CB_MAX_LENGTH, 0, 0);
						   0, 0);
		if (status) {
		if (ret) {
			IPW_DEBUG_FW_INFO(": Failed\n");
			IPW_DEBUG_FW_INFO(": Failed\n");
			return -1;
			return -1;
		} else
		} else
			IPW_DEBUG_FW_INFO(": Added new cb\n");
			IPW_DEBUG_FW_INFO(": Added new cb\n");

		src_offset += CB_MAX_LENGTH;
		dest_offset += CB_MAX_LENGTH;
		bytes_left -= CB_MAX_LENGTH;
	}

	/* add the buffer tail */
	if (bytes_left > 0) {
		status =
		    ipw_fw_dma_add_command_block(priv, src_phys + src_offset,
						 dest_address + dest_offset,
						 bytes_left, 0, 0);
		if (status) {
			IPW_DEBUG_FW_INFO(": Failed on the buffer tail\n");
			return -1;
		} else
			IPW_DEBUG_FW_INFO
			    (": Adding new cb - the buffer tail\n");
	}
	}


	IPW_DEBUG_FW("<< \n");
	IPW_DEBUG_FW("<< \n");
@@ -3160,59 +3142,91 @@ static int ipw_load_ucode(struct ipw_priv *priv, u8 * data, size_t len)


static int ipw_load_firmware(struct ipw_priv *priv, u8 * data, size_t len)
static int ipw_load_firmware(struct ipw_priv *priv, u8 * data, size_t len)
{
{
	int rc = -1;
	int ret = -1;
	int offset = 0;
	int offset = 0;
	struct fw_chunk *chunk;
	struct fw_chunk *chunk;
	dma_addr_t shared_phys;
	int total_nr = 0;
	u8 *shared_virt;
	int i;
	struct pci_pool *pool;
	u32 *virts[CB_NUMBER_OF_ELEMENTS_SMALL];
	dma_addr_t phys[CB_NUMBER_OF_ELEMENTS_SMALL];


	IPW_DEBUG_TRACE("<< : \n");
	IPW_DEBUG_TRACE("<< : \n");
	shared_virt = pci_alloc_consistent(priv->pci_dev, len, &shared_phys);


	if (!shared_virt)
	pool = pci_pool_create("ipw2200", priv->pci_dev, CB_MAX_LENGTH, 0, 0);
	if (!pool) {
		IPW_ERROR("pci_pool_create failed\n");
		return -ENOMEM;
		return -ENOMEM;

	}
	memmove(shared_virt, data, len);


	/* Start the Dma */
	/* Start the Dma */
	rc = ipw_fw_dma_enable(priv);
	ret = ipw_fw_dma_enable(priv);


	/* the DMA is already ready this would be a bug. */
	/* the DMA is already ready this would be a bug. */
	BUG_ON(priv->sram_desc.last_cb_index > 0);
	BUG_ON(priv->sram_desc.last_cb_index > 0);


	do {
	do {
		u32 chunk_len;
		u8 *start;
		int size;
		int nr = 0;

		chunk = (struct fw_chunk *)(data + offset);
		chunk = (struct fw_chunk *)(data + offset);
		offset += sizeof(struct fw_chunk);
		offset += sizeof(struct fw_chunk);
		chunk_len = le32_to_cpu(chunk->length);
		start = data + offset;

		nr = (chunk_len + CB_MAX_LENGTH - 1) / CB_MAX_LENGTH;
		for (i = 0; i < nr; i++) {
			virts[total_nr] = pci_pool_alloc(pool, GFP_KERNEL,
							 &phys[total_nr]);
			if (!virts[total_nr]) {
				ret = -ENOMEM;
				goto out;
			}
			size = min_t(u32, chunk_len - i * CB_MAX_LENGTH,
				     CB_MAX_LENGTH);
			memcpy(virts[total_nr], start, size);
			start += size;
			total_nr++;
			/* We don't support fw chunk larger than 64*8K */
			BUG_ON(total_nr > CB_NUMBER_OF_ELEMENTS_SMALL);
		}

		/* build DMA packet and queue up for sending */
		/* build DMA packet and queue up for sending */
		/* dma to chunk->address, the chunk->length bytes from data +
		/* dma to chunk->address, the chunk->length bytes from data +
		 * offeset*/
		 * offeset*/
		/* Dma loading */
		/* Dma loading */
		rc = ipw_fw_dma_add_buffer(priv, shared_phys + offset,
		ret = ipw_fw_dma_add_buffer(priv, &phys[total_nr - nr],
					   le32_to_cpu(chunk->address),
					    nr, le32_to_cpu(chunk->address),
					   le32_to_cpu(chunk->length));
					    chunk_len);
		if (rc) {
		if (ret) {
			IPW_DEBUG_INFO("dmaAddBuffer Failed\n");
			IPW_DEBUG_INFO("dmaAddBuffer Failed\n");
			goto out;
			goto out;
		}
		}


		offset += le32_to_cpu(chunk->length);
		offset += chunk_len;
	} while (offset < len);
	} while (offset < len);


	/* Run the DMA and wait for the answer */
	/* Run the DMA and wait for the answer */
	rc = ipw_fw_dma_kick(priv);
	ret = ipw_fw_dma_kick(priv);
	if (rc) {
	if (ret) {
		IPW_ERROR("dmaKick Failed\n");
		IPW_ERROR("dmaKick Failed\n");
		goto out;
		goto out;
	}
	}


	rc = ipw_fw_dma_wait(priv);
	ret = ipw_fw_dma_wait(priv);
	if (rc) {
	if (ret) {
		IPW_ERROR("dmaWaitSync Failed\n");
		IPW_ERROR("dmaWaitSync Failed\n");
		goto out;
		goto out;
	}
	}
 out:
 out:
	pci_free_consistent(priv->pci_dev, len, shared_virt, shared_phys);
	for (i = 0; i < total_nr; i++)
	return rc;
		pci_pool_free(pool, virts[i], phys[i]);

	pci_pool_destroy(pool);

	return ret;
}
}


/* stop nic */
/* stop nic */
+2 −2
Original line number Original line Diff line number Diff line
@@ -61,7 +61,7 @@ psched_tdiff_bounded(psched_time_t tv1, psched_time_t tv2, psched_time_t bound)
}
}


struct qdisc_watchdog {
struct qdisc_watchdog {
	struct tasklet_hrtimer	timer;
	struct hrtimer	timer;
	struct Qdisc	*qdisc;
	struct Qdisc	*qdisc;
};
};


+1 −1
Original line number Original line Diff line number Diff line
@@ -1025,6 +1025,7 @@ struct sock *sk_alloc(struct net *net, int family, gfp_t priority,
		sk->sk_prot = sk->sk_prot_creator = prot;
		sk->sk_prot = sk->sk_prot_creator = prot;
		sock_lock_init(sk);
		sock_lock_init(sk);
		sock_net_set(sk, get_net(net));
		sock_net_set(sk, get_net(net));
		atomic_set(&sk->sk_wmem_alloc, 1);
	}
	}


	return sk;
	return sk;
@@ -1872,7 +1873,6 @@ void sock_init_data(struct socket *sock, struct sock *sk)
	 */
	 */
	smp_wmb();
	smp_wmb();
	atomic_set(&sk->sk_refcnt, 1);
	atomic_set(&sk->sk_refcnt, 1);
	atomic_set(&sk->sk_wmem_alloc, 1);
	atomic_set(&sk->sk_drops, 0);
	atomic_set(&sk->sk_drops, 0);
}
}
EXPORT_SYMBOL(sock_init_data);
EXPORT_SYMBOL(sock_init_data);
+7 −5
Original line number Original line Diff line number Diff line
@@ -458,7 +458,7 @@ EXPORT_SYMBOL(qdisc_warn_nonwc);
static enum hrtimer_restart qdisc_watchdog(struct hrtimer *timer)
static enum hrtimer_restart qdisc_watchdog(struct hrtimer *timer)
{
{
	struct qdisc_watchdog *wd = container_of(timer, struct qdisc_watchdog,
	struct qdisc_watchdog *wd = container_of(timer, struct qdisc_watchdog,
						 timer.timer);
						 timer);


	wd->qdisc->flags &= ~TCQ_F_THROTTLED;
	wd->qdisc->flags &= ~TCQ_F_THROTTLED;
	__netif_schedule(qdisc_root(wd->qdisc));
	__netif_schedule(qdisc_root(wd->qdisc));
@@ -468,8 +468,8 @@ static enum hrtimer_restart qdisc_watchdog(struct hrtimer *timer)


void qdisc_watchdog_init(struct qdisc_watchdog *wd, struct Qdisc *qdisc)
void qdisc_watchdog_init(struct qdisc_watchdog *wd, struct Qdisc *qdisc)
{
{
	tasklet_hrtimer_init(&wd->timer, qdisc_watchdog,
	hrtimer_init(&wd->timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS);
			     CLOCK_MONOTONIC, HRTIMER_MODE_ABS);
	wd->timer.function = qdisc_watchdog;
	wd->qdisc = qdisc;
	wd->qdisc = qdisc;
}
}
EXPORT_SYMBOL(qdisc_watchdog_init);
EXPORT_SYMBOL(qdisc_watchdog_init);
@@ -485,13 +485,13 @@ void qdisc_watchdog_schedule(struct qdisc_watchdog *wd, psched_time_t expires)
	wd->qdisc->flags |= TCQ_F_THROTTLED;
	wd->qdisc->flags |= TCQ_F_THROTTLED;
	time = ktime_set(0, 0);
	time = ktime_set(0, 0);
	time = ktime_add_ns(time, PSCHED_TICKS2NS(expires));
	time = ktime_add_ns(time, PSCHED_TICKS2NS(expires));
	tasklet_hrtimer_start(&wd->timer, time, HRTIMER_MODE_ABS);
	hrtimer_start(&wd->timer, time, HRTIMER_MODE_ABS);
}
}
EXPORT_SYMBOL(qdisc_watchdog_schedule);
EXPORT_SYMBOL(qdisc_watchdog_schedule);


void qdisc_watchdog_cancel(struct qdisc_watchdog *wd)
void qdisc_watchdog_cancel(struct qdisc_watchdog *wd)
{
{
	tasklet_hrtimer_cancel(&wd->timer);
	hrtimer_cancel(&wd->timer);
	wd->qdisc->flags &= ~TCQ_F_THROTTLED;
	wd->qdisc->flags &= ~TCQ_F_THROTTLED;
}
}
EXPORT_SYMBOL(qdisc_watchdog_cancel);
EXPORT_SYMBOL(qdisc_watchdog_cancel);
@@ -1456,6 +1456,8 @@ static int tc_fill_tclass(struct sk_buff *skb, struct Qdisc *q,
	nlh = NLMSG_NEW(skb, pid, seq, event, sizeof(*tcm), flags);
	nlh = NLMSG_NEW(skb, pid, seq, event, sizeof(*tcm), flags);
	tcm = NLMSG_DATA(nlh);
	tcm = NLMSG_DATA(nlh);
	tcm->tcm_family = AF_UNSPEC;
	tcm->tcm_family = AF_UNSPEC;
	tcm->tcm__pad1 = 0;
	tcm->tcm__pad2 = 0;
	tcm->tcm_ifindex = qdisc_dev(q)->ifindex;
	tcm->tcm_ifindex = qdisc_dev(q)->ifindex;
	tcm->tcm_parent = q->handle;
	tcm->tcm_parent = q->handle;
	tcm->tcm_handle = q->handle;
	tcm->tcm_handle = q->handle;
Loading