Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 592d372a authored by Alex Dubov's avatar Alex Dubov Committed by Pierre Ossman
Browse files

tifm_sd: remove wait for power off on remove 



This wait was needed because of the mmc layer failure to wait for completion
of all outstanding commands before host removal. It should be fixed now in
the mmc layer.

Signed-off-by: default avatarAlex Dubov <oakad@yahoo.com>
Signed-off-by: default avatarPierre Ossman <drzeus@drzeus.cx>
parent b039d4a1

drivers/mmc/tifm_sd.c

+10 −15
Original line number Original line Diff line number Diff line
@@ -80,7 +80,6 @@ typedef enum { 
enum {

enum {

	FIFO_RDY   = 0x0001,     /* hardware dependent value */

	FIFO_RDY   = 0x0001,     /* hardware dependent value */

	EJECT      = 0x0004,

	EJECT      = 0x0004,

	EJECT_DONE = 0x0008,

	CARD_BUSY  = 0x0010,

	CARD_BUSY  = 0x0010,

	OPENDRAIN  = 0x0040,     /* hardware dependent value */

	OPENDRAIN  = 0x0040,     /* hardware dependent value */

	CARD_EVENT = 0x0100,     /* hardware dependent value */

	CARD_EVENT = 0x0100,     /* hardware dependent value */
@@ -99,7 +98,6 @@ struct tifm_sd { 
	struct tasklet_struct finish_tasklet;

	struct tasklet_struct finish_tasklet;

	struct timer_list     timer;

	struct timer_list     timer;

	struct mmc_request    *req;

	struct mmc_request    *req;

	wait_queue_head_t     notify;





	size_t                written_blocks;

	size_t                written_blocks;

	size_t                buffer_size;

	size_t                buffer_size;
@@ -738,12 +736,6 @@ static void tifm_sd_ios(struct mmc_host *mmc, struct mmc_ios *ios) 
	/* chip_select : maybe later */

	/* chip_select : maybe later */

	//vdd

	//vdd

	//power is set before probe / after remove

	//power is set before probe / after remove

	//I believe, power_off when already marked for eject is sufficient to

	// allow removal.

	if ((host->flags & EJECT) && ios->power_mode == MMC_POWER_OFF) {

		host->flags |= EJECT_DONE;

		wake_up_all(&host->notify);

	}





	spin_unlock_irqrestore(&sock->lock, flags);

	spin_unlock_irqrestore(&sock->lock, flags);

}

}
@@ -854,7 +846,6 @@ static int tifm_sd_probe(struct tifm_dev *sock) 
	host->dev = sock;

	host->dev = sock;

	host->timeout_jiffies = msecs_to_jiffies(1000);

	host->timeout_jiffies = msecs_to_jiffies(1000);





	init_waitqueue_head(&host->notify);

	tasklet_init(&host->finish_tasklet,

	tasklet_init(&host->finish_tasklet,

		     no_dma ? tifm_sd_end_cmd_nodma : tifm_sd_end_cmd,

		     no_dma ? tifm_sd_end_cmd_nodma : tifm_sd_end_cmd,

		     (unsigned long)host);

		     (unsigned long)host);
@@ -896,28 +887,32 @@ static void tifm_sd_remove(struct tifm_dev *sock) 
	struct tifm_sd *host = mmc_priv(mmc);

	struct tifm_sd *host = mmc_priv(mmc);

	unsigned long flags;

	unsigned long flags;





	del_timer_sync(&host->timer);

	spin_lock_irqsave(&sock->lock, flags);

	host->flags |= EJECT;

	writel(0, sock->addr + SOCK_MMCSD_INT_ENABLE);

	writel(0, sock->addr + SOCK_MMCSD_INT_ENABLE);

	mmiowb();

	mmiowb();

	spin_unlock_irqrestore(&sock->lock, flags);



	tasklet_kill(&host->finish_tasklet);



	spin_lock_irqsave(&sock->lock, flags);

	spin_lock_irqsave(&sock->lock, flags);

	host->flags |= EJECT;

	if (host->req) {

	if (host->req) {

		writel(TIFM_FIFO_INT_SETALL,

		writel(TIFM_FIFO_INT_SETALL,

		       sock->addr + SOCK_DMA_FIFO_INT_ENABLE_CLEAR);

		       sock->addr + SOCK_DMA_FIFO_INT_ENABLE_CLEAR);

		writel(0, sock->addr + SOCK_DMA_FIFO_INT_ENABLE_SET);

		writel(0, sock->addr + SOCK_DMA_FIFO_INT_ENABLE_SET);

		host->req->cmd->error = MMC_ERR_TIMEOUT;

		if (host->req->stop)

			host->req->stop->error = MMC_ERR_TIMEOUT;

		tasklet_schedule(&host->finish_tasklet);

		tasklet_schedule(&host->finish_tasklet);

	}

	}

	spin_unlock_irqrestore(&sock->lock, flags);

	spin_unlock_irqrestore(&sock->lock, flags);

	wait_event_timeout(host->notify, host->flags & EJECT_DONE,

			   host->timeout_jiffies);

	tasklet_kill(&host->finish_tasklet);

	mmc_remove_host(mmc);

	mmc_remove_host(mmc);

	dev_dbg(&sock->dev, "after remove\n");





	/* The meaning of the bit majority in this constant is unknown. */

	/* The meaning of the bit majority in this constant is unknown. */

	writel(0xfff8 & readl(sock->addr + SOCK_CONTROL),

	writel(0xfff8 & readl(sock->addr + SOCK_CONTROL),

	       sock->addr + SOCK_CONTROL);

	       sock->addr + SOCK_CONTROL);





	tifm_set_drvdata(sock, NULL);

	mmc_free_host(mmc);

	mmc_free_host(mmc);

}

}