Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 590b0b97 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

Staging: asus_oled: fix up some sysfs attribute permissions 



They should not be writable by any user

Reported-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Cc: Jakub Schmidtke <sjakub@gmail.com>
Cc: stable <stable@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent e53beacd

drivers/staging/asus_oled/asus_oled.c

+4 −4
Original line number Diff line number Diff line
@@ -620,13 +620,13 @@ static ssize_t class_set_picture(struct device *device, 


#define ASUS_OLED_DEVICE_ATTR(_file)		dev_attr_asus_oled_##_file



static DEVICE_ATTR(asus_oled_enabled, S_IWUGO | S_IRUGO,

static DEVICE_ATTR(asus_oled_enabled, S_IRUSR | S_IRUGO,

		   get_enabled, set_enabled);

static DEVICE_ATTR(asus_oled_picture, S_IWUGO , NULL, set_picture);

static DEVICE_ATTR(asus_oled_picture, S_IRUSR , NULL, set_picture);



static DEVICE_ATTR(enabled, S_IWUGO | S_IRUGO,

static DEVICE_ATTR(enabled, S_IRUSR | S_IRUGO,

		   class_get_enabled, class_set_enabled);

static DEVICE_ATTR(picture, S_IWUGO, NULL, class_set_picture);

static DEVICE_ATTR(picture, S_IRUSR, NULL, class_set_picture);



static int asus_oled_probe(struct usb_interface *interface,

			   const struct usb_device_id *id)