Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 58dd8258 authored by Thomas Klein's avatar Thomas Klein Committed by Jeff Garzik
Browse files

ehea: Reworked rcv queue handling to log only fatal errors 



Prevent driver from brawly logging packet checksum errors.

Signed-off-by: default avatarThomas Klein <tklein@de.ibm.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 7393b87c

drivers/net/ehea/ehea.h

+1 −1
Original line number Diff line number Diff line
@@ -40,7 +40,7 @@ 
#include <asm/io.h>



#define DRV_NAME	"ehea"

#define DRV_VERSION	"EHEA_0082"

#define DRV_VERSION	"EHEA_0083"



/* eHEA capability flags */

#define DLPAR_PORT_ADD_REM 1

drivers/net/ehea/ehea_main.c

+5 −6
Original line number Diff line number Diff line
@@ -410,11 +410,6 @@ static int ehea_treat_poll_error(struct ehea_port_res *pr, int rq, 
	if (cqe->status & EHEA_CQE_STAT_ERR_CRC)

		pr->p_stats.err_frame_crc++;



	if (netif_msg_rx_err(pr->port)) {

		ehea_error("CQE Error for QP %d", pr->qp->init_attr.qp_nr);

		ehea_dump(cqe, sizeof(*cqe), "CQE");

	}



	if (rq == 2) {

		*processed_rq2 += 1;

		skb = get_skb_by_index(pr->rq2_skba.arr, pr->rq2_skba.len, cqe);
@@ -426,7 +421,11 @@ static int ehea_treat_poll_error(struct ehea_port_res *pr, int rq, 
	}



	if (cqe->status & EHEA_CQE_STAT_FAT_ERR_MASK) {

		ehea_error("Critical receive error. Resetting port.");

		if (netif_msg_rx_err(pr->port)) {

			ehea_error("Critical receive error for QP %d. "

				   "Resetting port.", pr->qp->init_attr.qp_nr);

			ehea_dump(cqe, sizeof(*cqe), "CQE");

		}

		schedule_work(&pr->port->reset_task);

		return 1;

	}

drivers/net/ehea/ehea_qmr.h

+2 −2
Original line number Diff line number Diff line
@@ -145,8 +145,8 @@ struct ehea_rwqe { 
#define EHEA_CQE_VLAN_TAG_XTRACT   0x0400



#define EHEA_CQE_TYPE_RQ           0x60

#define EHEA_CQE_STAT_ERR_MASK     0x720F

#define EHEA_CQE_STAT_FAT_ERR_MASK 0x1F

#define EHEA_CQE_STAT_ERR_MASK     0x700F

#define EHEA_CQE_STAT_FAT_ERR_MASK 0xF

#define EHEA_CQE_STAT_ERR_TCP      0x4000

#define EHEA_CQE_STAT_ERR_IP       0x2000

#define EHEA_CQE_STAT_ERR_CRC      0x1000