Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 57e94d86 authored by Namhyung Kim's avatar Namhyung Kim Committed by Jan Kara
Browse files

ext3: Remove unnecessary casts on bh->b_data 



bh->b_data is already a pointer to char so casts to 'char *' should
be meaningless. Remove them.

Signed-off-by: default avatarNamhyung Kim <namhyung@gmail.com>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent df0d6b8f

fs/ext3/balloc.c

+2 −2
Original line number Diff line number Diff line
@@ -792,9 +792,9 @@ find_next_usable_block(ext3_grpblk_t start, struct buffer_head *bh, 
	if (here < 0)

		here = 0;



	p = ((char *)bh->b_data) + (here >> 3);

	p = bh->b_data + (here >> 3);

	r = memscan(p, 0, ((maxblocks + 7) >> 3) - (here >> 3));

	next = (r - ((char *)bh->b_data)) << 3;

	next = (r - bh->b_data) << 3;



	if (next < maxblocks && next >= start && ext3_test_allocatable(next, bh))

		return next;

fs/ext3/super.c

+3 −3
Original line number Diff line number Diff line
@@ -1654,7 +1654,7 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) 
	 * Note: s_es must be initialized as soon as possible because

	 *       some ext3 macro-instructions depend on its value

	 */

	es = (struct ext3_super_block *) (((char *)bh->b_data) + offset);

	es = (struct ext3_super_block *) (bh->b_data + offset);

	sbi->s_es = es;

	sb->s_magic = le16_to_cpu(es->s_magic);

	if (sb->s_magic != EXT3_SUPER_MAGIC)
@@ -1765,7 +1765,7 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) 
			       "error: can't read superblock on 2nd try");

			goto failed_mount;

		}

		es = (struct ext3_super_block *)(((char *)bh->b_data) + offset);

		es = (struct ext3_super_block *)(bh->b_data + offset);

		sbi->s_es = es;

		if (es->s_magic != cpu_to_le16(EXT3_SUPER_MAGIC)) {

			ext3_msg(sb, KERN_ERR,
@@ -2168,7 +2168,7 @@ static journal_t *ext3_get_dev_journal(struct super_block *sb, 
		goto out_bdev;

	}



	es = (struct ext3_super_block *) (((char *)bh->b_data) + offset);

	es = (struct ext3_super_block *) (bh->b_data + offset);

	if ((le16_to_cpu(es->s_magic) != EXT3_SUPER_MAGIC) ||

	    !(le32_to_cpu(es->s_feature_incompat) &

	      EXT3_FEATURE_INCOMPAT_JOURNAL_DEV)) {