Commit 57b48ab4 authored Sep 15, 2015 by Jarkko Nikula Committed by Mark Brown Sep 16, 2015

spi: bfin-sport: Calculate transfer speed unconditionally

SPI core validates the transfer speed and defaults to spi->max_speed_hz in
case the transfer speed is not set so code here won't use the
chip->baud value (which is derived from spi->max_speed_hz).

Please note driver uses chip->baud at the beginning of message transmission
by calling the bfin_sport_spi_restore_state() but then programs per
transfer speed in bfin_sport_spi_pump_transfers(). I'm not familiar with
the HW so I don't know would it be possible to remove chip->baud completely
by either using constant value in bfin_sport_spi_restore_state() or by
removing the tclkdiv register write there.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 6ff33f39

drivers/spi/spi-bfin-sport.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -352,10 +352,7 @@ bfin_sport_spi_pump_transfers(unsigned long data)
		transfer = drv_data->cur_transfer;
		chip = drv_data->cur_chip;

		if (transfer->speed_hz)
		transfer_speed = bfin_sport_hz_to_spi_baud(transfer->speed_hz);
		else
		transfer_speed = chip->baud;
		bfin_write(&drv_data->regs->tclkdiv, transfer_speed);
		SSYNC();