Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 571f2c11 authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller
Browse files

qlcnic: constify qlcnic_mbx_ops structure 



The only instance of a qlcnic_mbx_ops structure is never modified.  Thus
the declaration of the structure and all references to the structure type
can be made const.

In the definition of the qlcnic_mailbox structure, the ops field is no
longer lined up with the other fields.  This was left as is, to avoid a lot
of trivial changes on the other lines.

Done with the help of Coccinelle.

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Acked-by: default avatarSony Chacko <sony.chacko@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6623c60d

drivers/net/ethernet/qlogic/qlcnic/qlcnic.h

+1 −1
Original line number Diff line number Diff line
@@ -1092,7 +1092,7 @@ struct qlcnic_filter_hash { 
struct qlcnic_mailbox {

	struct workqueue_struct	*work_q;

	struct qlcnic_adapter	*adapter;

	struct qlcnic_mbx_ops	*ops;

	const struct qlcnic_mbx_ops *ops;

	struct work_struct	work;

	struct completion	completion;

	struct list_head	cmd_q;

drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c

+2 −2
Original line number Diff line number Diff line
@@ -4048,7 +4048,7 @@ static void qlcnic_83xx_mailbox_worker(struct work_struct *work) 
	struct qlcnic_mailbox *mbx = container_of(work, struct qlcnic_mailbox,

						  work);

	struct qlcnic_adapter *adapter = mbx->adapter;

	struct qlcnic_mbx_ops *mbx_ops = mbx->ops;

	const struct qlcnic_mbx_ops *mbx_ops = mbx->ops;

	struct device *dev = &adapter->pdev->dev;

	atomic_t *rsp_status = &mbx->rsp_status;

	struct list_head *head = &mbx->cmd_q;
@@ -4098,7 +4098,7 @@ static void qlcnic_83xx_mailbox_worker(struct work_struct *work) 
	}

}



static struct qlcnic_mbx_ops qlcnic_83xx_mbx_ops = {

static const struct qlcnic_mbx_ops qlcnic_83xx_mbx_ops = {

	.enqueue_cmd    = qlcnic_83xx_enqueue_mbx_cmd,

	.dequeue_cmd    = qlcnic_83xx_dequeue_mbx_cmd,

	.decode_resp    = qlcnic_83xx_decode_mbx_rsp,