Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 56c2477f authored by Johannes Berg's avatar Johannes Berg Committed by Emmanuel Grumbach
Browse files

iwlwifi: pcie: make FH debugfs file code easier to understand 



The code seems fine, as buf won't be assigned when an error
is returned, but checking for the error first is easier to
understand.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
parent 189fa2fa

drivers/net/wireless/iwlwifi/pcie/trans.c

+8 −9
Original line number Diff line number Diff line
@@ -1434,16 +1434,15 @@ static ssize_t iwl_dbgfs_fh_reg_read(struct file *file, 
{

	struct iwl_trans *trans = file->private_data;

	char *buf = NULL;

	int pos = 0;

	ssize_t ret = -EFAULT;

	ssize_t ret;



	ret = pos = iwl_dump_fh(trans, &buf);

	if (buf) {

		ret = simple_read_from_buffer(user_buf,

					      count, ppos, buf, pos);

	ret = iwl_dump_fh(trans, &buf);

	if (ret < 0)

		return ret;

	if (!buf)

		return -EINVAL;

	ret = simple_read_from_buffer(user_buf, count, ppos, buf, ret);

	kfree(buf);

	}



	return ret;

}